Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing old rd syntax #191

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Removing old rd syntax #191

merged 6 commits into from
Jan 10, 2024

Conversation

kartikeyakirar
Copy link
Contributor

this is part of #189

I noticed some old syntax that was not previously checked, so I am creating a separate pull request for it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------
R/qenv-concat.R             10       0  100.00%
R/qenv-constructor.R        16      13  18.75%   54-93
R/qenv-eval_code.R          52       2  96.15%   100, 109
R/qenv-get_code.R           20       1  95.00%   38
R/qenv-get_env.R             3       3  0.00%    23-31
R/qenv-get_var.R            19       0  100.00%
R/qenv-get_warnings.R       24       0  100.00%
R/qenv-join.R               46       0  100.00%
R/qenv-show.R                1       1  0.00%    19
R/qenv-within.R              8       0  100.00%
R/utils.R                   10       0  100.00%
TOTAL                      209      20  90.43%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a462844

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Unit Tests Summary

  1 files    9 suites   0s ⏱️
 62 tests  62 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit a462844.

♻️ This comment has been updated with latest results.

@donyunardi donyunardi mentioned this pull request Jan 10, 2024
Closed
33 tasks
@kartikeyakirar kartikeyakirar enabled auto-merge (squash) January 10, 2024 17:45
averissimo
averissimo reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Minor comments related to \cr.

  • One \cr is being displayed in the man page. Please remove this.
  • Consider replacing other \cr with markdown's 2 new lines, but very optional.

(Didn't mark as approved as auto-merge is on and documentation needs to be re-generated if suggestions are integrated)

R/qenv-join.R Outdated Show resolved Hide resolved
R/qenv-join.R Outdated Show resolved Hide resolved
R/qenv-join.R Outdated Show resolved Hide resolved
R/qenv-join.R Outdated Show resolved Hide resolved
kartikeyakirar and others added 4 commits January 10, 2024 23:58
@kartikeyakirar @averissimo
Update R/qenv-join.R
c6f871f 
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@dependabot-preview
[skip actions] Roxygen Man Pages Auto Update
ebac341
@kartikeyakirar
@averissimo
e5e38f2
@kartikeyakirar
Merge branch 'old_rd_syntax@main' of https://github.com/insightsengin…
c5d2723 
…eering/teal.code into old_rd_syntax@main
donyunardi
donyunardi reviewed Jan 10, 2024
View reviewed changes
R/qenv-join.R Outdated Show resolved Hide resolved
donyunardi
donyunardi reviewed Jan 10, 2024
View reviewed changes
R/qenv-join.R Outdated Show resolved Hide resolved
donyunardi
donyunardi approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@kartikeyakirar kartikeyakirar merged commit d16ddd7 into main Jan 10, 2024
24 checks passed
@kartikeyakirar kartikeyakirar deleted the old_rd_syntax@main branch January 10, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donyunardi donyunardi donyunardi approved these changes

@averissimo averissimo Awaiting requested review from averissimo

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartikeyakirar @averissimo @donyunardi